ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.09k stars 2.23k forks source link

User profile overlay does not handle 404 errors correctly #16387

Closed bdach closed 2 years ago

bdach commented 2 years ago

Discussed in https://github.com/ppy/osu/discussions/16383

Originally posted by **Theighlin** January 9, 2022 I was casually browsing the first spotlight room that was made in lazer and in the first beatmap i came across a user whose overlay doesn't load. The user in question doesn't come up when searching for his name on the website and i tried looking for him with the id that was in the logs and it seems that the account isn't accessible. game: https://user-images.githubusercontent.com/53081750/148687098-6badef95-d411-4474-9cf5-b784ad4f9dfe.mp4 web: ![image](https://user-images.githubusercontent.com/53081750/148687119-baa13039-2ad5-429b-8386-555e47f91c60.png) from network logs: ``` 2022-01-09 14:34:31 [verbose]: Performing request osu.Game.Online.API.Requests.GetUserRequest 2022-01-09 14:34:31 [verbose]: Request to https://osu.ppy.sh/api/v2/users/11719249/?key=id failed with System.Net.WebException: NotFound. 2022-01-09 14:34:31 [verbose]: Response was: {"error":null} 2022-01-09 14:34:31 [verbose]: Failing request osu.Game.Online.API.Requests.GetUserRequest (osu.Game.Online.API.APIException: Exception of type 'osu.Game.Online.API.APIException' was thrown. 2022-01-09 14:34:31 [verbose]: ---> System.Net.WebException: NotFound 2022-01-09 14:34:31 [verbose]: --- End of inner exception stack trace ---)```
LittleEndu commented 2 years ago

This title could be confused with #8722 (if this issue doesn't count as a duplicate)

Theighlin commented 2 years ago

This title could be confused with #8722 (if this issue doesn't count as a duplicate)

Ah sorry, I knew i saw something like this somewhere before, didn't think of this as an http error (i thought it was a valid response to a user that can't be seen). Close this if you deem it appropriate

bdach commented 2 years ago

closing as duplicate.