search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.52k stars 2.31k forks source link

"No beatmaps available" shouldn't always show when no beatmap is currently selected #17666

Open jojothka123 opened 2 years ago

jojothka123 commented 2 years ago

Type

Cosmetic

Bug description

music playback overlay displays inaccurate text when in a multiplayer lobby without having downloaded the map

Screenshots or videos

osu_2022-04-05_19-57-03

Version

2022.405.0-lazer

Logs

network.log performance.log runtime.log updater.log database.log

KantoChampion commented 2 years ago

So in the event a beatmap is not selected, this message is displayed? In other words, beatmaps are available and the message should prompt the user to instead, "select a beatmap"?

peppy commented 2 years ago

What do you want it to display in this case? Please provide a suggestion.

jojothka123 commented 2 years ago

No, the message is displayed when the selected beatmap has not yet been loaded. I'd suggest either continuing to play the previously playing song or changing the text to "selected beatmap not loaded! / please load the selected beatmap!".

LukynkaCZE commented 1 year ago

I think it would make sense to just globally change it to something like "no beatmap selected! // please select or load a beatmap!" That would cover both situations of not having any beatmaps loaded and not having beatmap selected in multiplayer room