search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.37k stars 2.29k forks source link

High Distance Snap allows for out-of-bounds hit object placement #18231

Open bdach opened 2 years ago

bdach commented 2 years ago

Just going to make an issue out of this one because this one is really an actual issue.

The solution is probably to just not snap to anything at all if the result is outside of bounds?

Discussed in https://github.com/ppy/osu/discussions/18229

Originally posted by **Walavouchey** May 11, 2022 the video below should explain the situation clearly: https://user-images.githubusercontent.com/36758269/167931995-1ef8f222-f0e9-45f6-b00e-5c702e0a6090.mp4 you can of course place things offscreen with the same technique too: https://user-images.githubusercontent.com/36758269/167933651-75ef8f73-d4d6-459c-afbb-22a753d08e6f.mp4 version: latest release (2022.509.0-lazer) logs: n/a
peppy commented 2 years ago

There's two different behaviours here as well: during placement you can incorrectly place outside the playfield (as long as the mouse is inside the playfield), while during selection/movement you can't place outside, but the snapping does max at the edge of the playfield, rather than prohibiting placement (preferred behaviour):

https://user-images.githubusercontent.com/191335/167988676-bfbefc73-a57a-494d-923c-76b9b5efd02e.mp4