search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.41k stars 2.29k forks source link

Display the resultant objects count after selecting conversion mods #18411

Open Coppertine opened 2 years ago

Coppertine commented 2 years ago

Type

Cosmetic

Bug description

Essentially, when using a mod that changes the state of the beatmap (that is a mod found in the Conversion seciton), the object values are not changed if a change is done to the beatmap.

Example to reproduce. (This can happen across any ruleset, including custom rulesets, but for consistency sake, mania would be used.)

  1. Set ruleset to Mania
  2. Enable Invert or Hold Off Mods and note the Note and Hold Note count. (Expected to see different values for Invert, and 0 Hold Note count for Hold Off Mod).

Screenshots or videos

osu_2022-05-25_22-09-33 Mania - No Mods

osu_2022-05-25_22-09-57 Mania - Hold Off Mod (on mania convert map)

osu_2022-05-25_22-10-25 Mania - Daycore + Hold Off Mod on 7 Key map

Version

2022.523.0-lazer

Logs

runtime.log performance.log network.log

frenzibyte commented 2 years ago

You're right in that the length part is a duplicate, it's a duplicate of https://github.com/ppy/osu/issues/10580.

Coppertine commented 2 years ago

Could remove all statements of length and modify to spesifty the WedgeText instead. Since the issue stated only talked about the AdvancedStatstics area and nothing about the length shown.