ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

Volume doesn't save on note overlapping with a hold note #19483

Closed Redd56 closed 1 year ago

Redd56 commented 2 years ago

Type

Game behaviour

Bug description

when in editor editing hitsounds sometimes the volume does not save added context: before i hit save and exit set both single hits to 33% volume and the hold to 0, save and come back and it just doesnt save it this has been happening alot in random spots on the map, some areas will save the volume and some will not

Screenshots or videos

https://user-images.githubusercontent.com/12189828/181995119-9188b9a2-d1ac-4a6f-9cda-792a765de1c3.mp4

Version

2022.731.1 lazer

Logs

database.log network.log performance.log runtime.log

Redd56 commented 2 years ago

may be related to https://github.com/ppy/osu/issues/15618

frenzibyte commented 2 years ago

Different volume specifications for objects on a specific time can't work because they'll all be encoded back to the stable format (which is one control point per time). May need to indicate that somehow, potentially by only showing one bubble rather than multiple at a time. That's not quite possible with the way editor timeline is structured (where each hitobject provides its own volume bubble).

peppy commented 2 years ago

The format should be fixed instead.

frenzibyte commented 2 years ago

Not sure how feasible that'll be though since it involves manipulating .osu files, unless it's fine changing the legacy beatmap encoder to include additional properties in control points? (I suppose that's the reason why we have lazer beatmaps set to v128)

peppy commented 1 year ago

This issue should be resolved via #23308.