search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.34k stars 2.28k forks source link

Unify HitObject hit windows #2013

Closed smoogipoo closed 6 years ago

smoogipoo commented 6 years ago

At the moment only taiko and mania have proper hit windows, and even then they use their own implementations. osu! likewise has its own implementation, but it doesn't scale with OD right now.

To start off, a good direction would be to extract mania's HitWindows class into osu.Game and add it to the base HitObject class, perhaps as a lazily-loaded member. Then we can use this class and the values contained within it for all rulesets - hopefully being able to balance all rulesets using the same hit window values.

Aergwyn commented 6 years ago

Wait wasn't OD in osu! done just recently? See #1938.

smoogipoo commented 6 years ago

Indeed it was, my mistake.