search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.41k stars 2.29k forks source link

Slider follow circle disappears after changing beatmap properties #20132

Open smoogipoo opened 2 years ago

smoogipoo commented 2 years ago

Discussed in https://github.com/ppy/osu/discussions/20128

Originally posted by **Feodor0090** September 5, 2022 Not sure how to explain it properly. https://user-images.githubusercontent.com/53872073/188335235-f13fe7cd-3c6a-406a-9cfb-d00bedb3e919.mp4 Steps: 1) Create a beatmap / start editing one. 2) Place a very long slider. 3) Be in it's middle. 4) Change beatmap's CS on "setup" tab. 5) Return to compose tab, try to seek a little 6) Notice that followcircle disappears at moment where you was when changing CS.
peppy commented 2 years ago

Tentatively assigning as I've started work on this, but not sure if I'll see it through to fruition.

Basic gist is that this transform code is being run at the current point in time when ApplyDefaults is called, clobbering any animations:

https://github.com/ppy/osu/blob/c2c2c505a4f2ab578afaff235e3c042e1e42bf00/osu.Game.Rulesets.Osu/Skinning/FollowCircle.cs#L53-L57