ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.38k stars 2.29k forks source link

Song carousel continuously scrolls without user input #20439

Open hburn7 opened 2 years ago

hburn7 commented 2 years ago

Type

Game behaviour

Bug description

The song carousel seems to continuously move without user input. I am unsure if it's due to having a very large amount of beatmaps (I believe I have >5,000 sets). Attached is an example of the encountered unexpected behaviour.

The only step to reproduce is to select a map in the selection screen and scroll up or down without changing selection.

Screenshots or videos

https://user-images.githubusercontent.com/38370573/192067877-52205d54-17cb-406f-81e4-19698ea8ab9e.mp4

Version

2022.923.1

Logs

performance.log performance-audio.log performance-draw.log performance-input.log performance-update.log runtime.log updater.log database.log network.log

ItsShamed commented 2 years ago

It seems like it's importing maps. If you just pressed "Import beatmaps from stable" then it's a totally normal behavior.

Or this might be something else. In both cases it's something I'm not surprised that it happens

2022-09-23 22:46:26 [verbose]: Found 8135 beatmap sets which require reprocessing.
hburn7 commented 2 years ago

It seems like it's importing maps. If you just pressed "Import beatmaps from stable" then it's a totally normal behavior.

Or this might be something else. In both cases it's something I'm not surprised that it happens

2022-09-23 22:46:26 [verbose]: Found 8135 beatmap sets which require reprocessing.

The 8135 sets makes sense because I had done a beatmap import a very long time ago (weeks and weeks ago) but what doesn't make sense is the background processing affecting the song select UX in such an inconvenient way. No maps are actively being imported while this scrolling is occurring. I am more than happy to provide more video context if requested.

peppy commented 2 years ago

So what is going on is that you're sorting by difficulty, and the difficulty of beatmaps is changing. If you are using keyboard navigation, then the screen will not scroll as it tracks the active selection. If you scroll using mouse, it exits the absolute scroll mode and the carousel will freely flow based on changes.

I agree it's probably not optimal and the frame of reference should be the current scroll position in cases where it's not tracking a specific beatmap as above.

hburn7 commented 2 years ago

Just thought I'd write back and say that now that my log reads:

2022-10-09 04:25:52 [verbose]: Found 0 beatmap sets which require reprocessing.

... song selection is significantly smoother and this updating doesn't occur. I wonder if there's a way to force this reprocessing or if the game needs to be left open for hours on end for it to happen in the background (for thousands of sets).

peppy commented 2 years ago

It shouldn't take hours, but it will pause if you're playing the game to avoid adding unnecessary overhead.