ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

Argon skin uses triangles elements when selecting another skin then re-selecting argon skin #20634

Closed enoslayd closed 1 year ago

enoslayd commented 2 years ago

Type

Cosmetic

Bug description

steps to reproduce

  1. argon must be selected by default when booting lazer
  2. play any maps on osu/mania while in argon skin (autoplay is affected too)
  3. select another skin (any skin) then select argon again
  4. argon will use triangles elements on both mania/osu

even when restarting gameplay or switching ruleset, it still uses triangles. the only way to use argon is to select argon then restart lazer

Screenshots or videos

when argon is selected by default osu_2022-10-07_08-01-59

argon when selecting another skin then going back to argon skin osu_2022-10-07_08-02-09

Version

2022.1008.0

Logs

database.log input.log legacy-ipc.log network.log performance.log runtime.log updater.log

peppy commented 2 years ago

@enoslayd I can't seem to reproduce this one, are you able to provide a video showing the process?

enoslayd commented 2 years ago

@enoslayd I can't seem to reproduce this one, are you able to provide a video showing the process?

Sorry for the late reply, ill try to record later

As a follow-up, this doesn't happen on my android device and i suspect that its only on my pc, ill check with a clean database later

enoslayd commented 2 years ago

here is the video https://user-images.githubusercontent.com/41866328/197964105-da762fdd-5f7c-4bff-a178-e8bddbc23b2b.mp4

also i tried with a clean database and apparently its caused by my database. i dont want to delete it since i have soooo many beatmaps (300+GB)

peppy commented 2 years ago

if you think it's caused by your database, could you please attach it? (zip client.realm and drag into github)

enoslayd commented 2 years ago

hello, its too large for github (and maybe email too) so ill email a gdrive link instead

peppy commented 1 year ago

@enoslayd did you happen to run any development builds during argon's development? ie. building yourself or running something provided by someone else?

enoslayd commented 1 year ago

Hello yes i did

peppy commented 1 year ago

Thanks. This should be an issue for only devs and not end users so I've sent you a fixed version of your database and will close the issue.

If anyone runs into this, you need to change the InstantiationInfo inside Skin for argon and triangles:

DefaultSkinArgon -> ArgonSkin DefaultSkinTriangles -> TrianglesSkin