search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.12k stars 2.25k forks source link

Something is wrong with `DrawableJudgement` pooling #20737

Open peppy opened 1 year ago

peppy commented 1 year ago

Yesterday I ran into a full game crash with the following:

[runtime] 2022-10-12 04:49:54 [verbose]: Unhandled exception has been denied .
Unhandled exception. System.ObjectDisposedException: Disposed Drawables may never be in the scene graph.
Object name: 'ArgonJudgementPiece'.
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()

I did some preliminary investigation but haven't come up with anything yet.

Potentially related to https://github.com/ppy/osu/issues/19908, although in my case I don't believe it was input triggered.

ppy-sentryintegration[bot] commented 1 year ago

Sentry issue: OSU-64R

ppy-sentryintegration[bot] commented 1 year ago

Sentry issue: OSU-3RE

ppy-sentryintegration[bot] commented 1 year ago

Sentry issue: OSU-7XH

ppy-sentryintegration[bot] commented 1 year ago

Sentry issue: OSU-N8

ppy-sentryintegration[bot] commented 1 year ago

Sentry issue: OSU-7PJ

bdach commented 1 year ago

Difficult to tell from the OP, but is there a chance that replay rewind was involved in this? Asking because if it is, then this may be #11980 or an adjacent issue.

peppy commented 1 year ago

Difficult to tell from the OP, but is there a chance that replay rewind was involved in this? Asking because if it is, then this may be #11980 or an adjacent issue.

Yes, it is only an issue during rewind.