ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.37k stars 2.29k forks source link

osu!mania Argon skin doesn't work with timing-based note colouring #20977

Open smoogipoo opened 2 years ago

smoogipoo commented 2 years ago

Type

Cosmetic

Bug description

Triangles Argon
image image

Screenshots or videos

No response

Version

bdc6755ee207ae535c3da441bb4c9270b50eb957

Logs

-

peppy commented 1 year ago

Bumping in priority since this is pretty broken.

We could either

Interested in more opinions on this.

We should also consider migrating the setting to the "Synesthesia" mod if this is a considerable change.

LOLZSICKA commented 11 months ago

the skin could be made to detect when the timing based coloring is enabled and make the notes become white instead of colored so that the timed colorings pop out much better. the glow when the notes get hit could also be colored to the note's color too.

peppy commented 11 months ago

the skin could be made to detect when the timing based coloring is enabled and make the notes become white instead of colored so that the timed colorings pop out much better. the glow when the notes get hit could also be colored to the note's color too.

This is mentioned directly above:

Replace the note colour (usually taken from the column)

peppy commented 6 months ago

@arflyte did you end up coming up with a way to show this on the argon skins?

arflyte commented 6 months ago

Need a lil bit more explanation. I'm not so sure, but is this regarding the colour of the long bars when activated?

mcendu commented 6 months ago

The notes, long note heads and tails look broken when timing-based note coloring is turned on, and some design is needed to properly adapt timing-based note coloring to Argon. My personal preference is to:

Replace the note colour (usually taken from the column)

with a color based on the timing of a note, but potential contrast problems are noted given the columns having different colored backgrounds.