Timing Selection goes back one when clicking on it.

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.37k stars 2.28k forks source link

Timing Selection goes back one when clicking on it. #21172

Closed Vadeblade closed 1 month ago

Vadeblade commented 2 years ago

Type

Game behaviour

Bug description

Timing selection I pick goes to an earlier one when selecting it.

Screenshots or videos

https://user-images.githubusercontent.com/20312791/200521560-b86bcbeb-e7c0-47f2-99b4-7b4b483b178e.mp4

Version

2022.1101.0-lazer

Logs

runtime.log updater.log database.log legacy-ipc.log network.log performance.log

peppy commented 2 years ago

Could you please attach the beatmap you are testing with (or a link to it)?

This is likely going to be a floating point precision issue.

Vadeblade commented 1 year ago

I've tried recreating the issue multiple times and couldn't do it. Immediately after I deleted most the timing points in the map after reporting since I need to for the timing of the song.

peppy commented 1 year ago

I can imagine that this can definitely happen due to the trackActivePoint flow running...

https://github.com/ppy/osu/blob/31a447fda0532fcf15f8c8251ca890c533386492/osu.Game/Screens/Edit/Timing/TimingScreen.cs#L171-L200

..at the same time a seek is performed, but will need a reliable repro case to figure out what is going on (the fact it's using clock.CurrentTimeAccurate should be enough in theory). If anyone happens to find one please leave more information.

Joehuu commented 1 month ago

Closing as the OP reproduced this on a custom beatmap and couldn't reproduce reliably after. Probably not an issue after https://github.com/ppy/osu/pull/29532 anyway.