search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.45k stars 2.3k forks source link

Mods settings restore to default after changing ruleset #21634

Closed BlestLace closed 1 year ago

BlestLace commented 1 year ago

Type

Game behaviour

Bug description

I just wanted to play a specific map with mods, and I tried osu!mania... I had dt at 0.10x and quickly changed over to mania, the song started playing much faster. Turns out, dt's setting had been changed over from 0.10x to 0.50x (default setting).

(in case you didn't know, dt stands for "double time".)

Screenshots or videos

I would greatly have posted a video here, but it's too big. I will post photos here, and you'll need to open them in order.

first second third fourth

Version

osu! 2022.1208.2-lazer

Logs

database.log input.log legacy-ipc.log network.log performance.log performance-draw.log performance-update.log runtime.log updater.log

bdach commented 1 year ago

I guess wanting mod settings to persist when changing rulesets is reasonable if we're keeping them enabled since #20758. It's a little tricky though because sometimes mods that have the same acronym don't exactly have the same set of settings in all rulesets.

peppy commented 1 year ago

Best effort sounds like a good path... just try-catch any failures to copy.