search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.45k stars 2.3k forks source link

Notes dissapear upon SV change in mania with Wind Up mode #21930

Closed Kwolium closed 6 months ago

Kwolium commented 1 year ago

Type

Game behaviour

Bug description

When playing 4k mania with Wind Up mode, some notes may dissappear and reappear in the leftmost column upon hitting SV change. This doesn't happen on other keys or Wind Down. It also appears on other skins.

Screenshots or videos

https://user-images.githubusercontent.com/72566596/209992395-2e3de6ef-d46d-45c7-8f65-b61f479cf63d.mp4

https://user-images.githubusercontent.com/72566596/209992419-f5d7e825-9d61-4de3-8c23-fc7c3c47b705.mp4

Version

2022.1227.0

Logs

No need

bdach commented 1 year ago

Can you link an example of a map that this happens on?

Kwolium commented 1 year ago

Can you link an example of a map that this happens on?

https://osu.ppy.sh/beatmapsets/555076#mania/1174927 https://osu.ppy.sh/beatmapsets/1878528#mania/3895702

these two from the videos

bdach commented 6 months ago

This looks fixed (can reproduce on version specified in OP, cannot on latest master) and I can't bisect it properly (probably due to cherrypicks into releases or whatever):

$ git bisect good master
status: waiting for bad commit, 1 good commit known

$ git bisect bad 2022.1227.0
Some good revs are not ancestors of the bad rev.
git bisect cannot work properly in this case.
Maybe you mistook good and bad revs?

so I'm just gonna close.