search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.04k stars 2.22k forks source link

Placing notes on top of slider or spinner end with distance snap enabled will instead get stuck. #21943

Open Trung0246 opened 1 year ago

Trung0246 commented 1 year ago

Type

Game behaviour

Bug description

Related to https://github.com/ppy/osu/issues/20940, thought I probably should open new issue since the method to get stuck is not exactly the same (basically same but different but whatever).

Same goes for spinner.

Screenshots or videos

https://user-images.githubusercontent.com/11626920/210060108-6737027c-5830-4c81-a93c-548753e3ecb6.mp4

https://user-images.githubusercontent.com/11626920/210060388-a80ebe59-c043-4b63-8af8-62433bb460bd.mp4

Version

2022.1228.0

Logs

database.log input.log legacy-ipc.log runtime.log updater.log network.log performance.log performance-audio.log performance-draw.log performance-input.log performance-update.log

bdach commented 1 year ago

This looks bad but I'm not sure what else should happen. With the grid snap as shown on the video, and the time interval between the notes where it gets "stuck", there are no snap grid lines shown because you can't physically fit any other notes. Should placement just be refused? Or be free-form? No idea.

Trung0246 commented 1 year ago

I guess the expected behavior could be the same as the linked merge: https://github.com/ppy/osu/pull/20943

peppy commented 1 year ago

I think this issue should be better explained as... "when distance snap is turned on and placing a hit object on top of another, time separation should be considered to be equal to one-beat-divisor"?

It has nothing to do with sliders/spinners, as this also breaks on placing circles on top of circles. Would appreciate if someone can confirm this sounds correct.

bdach commented 1 year ago

I'm actually really confused because each of the three comments in this thread reads like it refers like an entirely different thing to me.

To me, the "buggy" thing looks to be "when there are two objects on subsequent beats, and you move the timeline between the beats with distance snap active, you can't place a note anywhere except for where the previous note is". For me that's possibly acceptable, but I'm not sure.