ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.08k stars 2.23k forks source link

Weird behaviour of hit circles #21989

Closed fobos103 closed 1 year ago

fobos103 commented 1 year ago

Type

Cosmetic

Bug description

Basically I changed my hit circles to be white and my slider hit circles to be blue in stable, because I had issues with reading a long time ago and it really helped me, but when I use the skin in lazer it "underflashes" the blue hit circle of the slider, same thing happens with the normal hit circles but since I use white hit circles its not nearly as noticeable. I don´t know how to best describe it, I believe it happens when the combo color would be changing, but I use single combo color and I never had this issue in stable. It might have to do something with the way the hit circles are drawn maybe. I recorded a video showcasing my problem, at roughly 1 minute I have made my best efforts to show the issue. I tried to fix this with various methods, like changing the combo color or making the "hitcircleoverlay" completely hollow, changing the color of the hit circles etc., everything with no luck. Also this exist for like a year now, basically ever since I started playing lazer, and no update fixed this issue. One more thing i have for some reason 3 lazer folders and I have no clue why or which is the correct one since all seems to have different files so I provided all 3 with video, I put "1" "2" "3" in front of the files, in the order I show them in the video.

Screenshots or videos

https://youtu.be/AER0DJLtRGI https://youtu.be/-v2uwOsDR7A

Version

All lazer versions so far

Logs

1database.log 1input.log 1performance.log 1runtime.log 1updater.log 2database.log 2input.log 2network.log 2performance.log 2runtime.log 2updater.log

bdach commented 1 year ago

Please upload the skin because without any comparison to stable I'm not even sure what I'm supposed to be looking for there.

fobos103 commented 1 year ago

https://drive.google.com/file/d/1Nm6bBodXEi0IfNzdmQZD2-AJv0fYNFXy/view?usp=sharing

fobos103 commented 1 year ago

So I did some more digging why this might happen and I found out that AR,CS and bpm of the beatmap does not matter, but this bug will not occur (in my testing) if the map is really short (no map in my collection that is less than 300 combo have this bug). Other thing is that the bug occurs at seemingly random points in the map but never (in my testing) in the first 200 combo. In longer maps (1000+ combo) it happens several times in the map but never occurring through the whole map. I made a video that should be helpful showcasing stable and lazer side by side, same skin,same map + I show my settings of the games at the end. (I tried my best to sync the replays) https://youtu.be/0pLleGcPYKA

peppy commented 1 year ago

Could you please provide timestamps from the youtube video where the issue is most visible?

NotGumballer91 commented 1 year ago

This has to be video quality issue, Right? It's been like this consistently throughout the video image

fobos103 commented 1 year ago

So in the 2nd video from 1:07 to 1:19 if you slow down the video you can see it quite clearly on the sliders. Its not visible on the slider itself its the hit circle that is weird. In this video https://youtu.be/AER0DJLtRGI that I posted with the bug I try my best to show it from roughly 1:15 to 1:55. Its not a video or an editing bug it really looks like this in the game as well. Screenshot_16

mbnkwm commented 1 year ago

those are kiai flashes, see #21747

fobos103 commented 1 year ago

I see so lets hope we will get a slider to change this setting because its really distracting

peppy commented 1 year ago

Handling in #21747.