search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.13k stars 2.25k forks source link

Appearance of featured artist filter in beatmap listing overlay is too subtle when enabled #22009

Closed bdach closed 3 months ago

bdach commented 1 year ago

Type

Cosmetic

Bug description

Leading to several issue reports that the overlay is returning incorrect results. Which it isn't, but we probably can do a better job at conveying it than it is done currently. The difference between the filter being enabled and disabled is just font weight.

Screenshots or videos

image

Top 2 lines: featured artist filter on/off. Bottom 2 lines: any other filter on/off. Side by side this appears to be more obvious, but in isolation it can be difficult to tell the difference.

Version

current master

Logs

-

peppy commented 1 year ago

I've been meaning to open an issue for this. It's very bad design as it exists right now, because it uses a different colour to the normal highlight colour it doesn't even look like it's selected, but just highlighted. Underline or background box may work. @arflyte please advise

It may also help to add a message to the "no results" display similar to song select, letting the user know to check their filters.

bdach commented 1 year ago

For whatever it's worth this is a design that exists. No idea at what stage of usability it is, but it's there.

It predates the featured artist filter but it has the green dots next to things to signal enabled state. Probably not a very good short-term solution if we want to avoid redesigning the entire search control though.

CX13BVA commented 1 year ago

Leading to several issue reports that the overlay is returning incorrect results. Which it isn't,

I was literally about to open an issue regarding "returning incorrect results", good thing I checked with Death first to confirm it's not just on my end. The "Featured artist" filter has almost zero visual difference between being enabled/disabled on my screen :/

peppy commented 1 year ago

That design doesn't make much sense based on how the tabs are arranged. "Featured artist" should be a filter on beatmap rather than a top level tab, unless that's intended for browsing the featured artist pages themselves (not implmented in game yet)?

bdach commented 1 year ago

Yeah I did not pay too much attention to the header on that design there. The filter control was more the point.

janneslessmann commented 1 year ago

Maybe it would help, to display a little "X" button besides the "Featured artists" filter?

mcendu commented 1 year ago

Probably make the text white-ish when selected as with other links.

gepbird commented 1 year ago

I'd love to see a "Don't show again" button when turning off featured artist filter.

frenzibyte commented 12 months ago

Turns out I had opened a duplicate issue thread for this. I'll just copy what I wrote in the other thread:

This happened to me a handful of times after not launching osu!(lazer) for a short period of time, and has also just been encountered by a user recently. Opening this issue thread to raise a bit of discussion before osu!(lazer) becomes ranked and many stable players switch to lazer (not sure if it deserves being included in the project though).

Part of this confusion likely rises from the fact that the osu! website does not enable the "featured artists" filter in beatmap listing by default. But I'm not sure if the website will have it enabled by default any time soon.

I'm not sure how much of noting is acceptable, but would maybe adding a line strip at the top of the search results stating that this is searching for beatmaps with the "featured artist" filter enabled? Or at the very least, maybe bring the filter to the right side of the search bar in some shape or form, e.g.:

CleanShot 2023-09-30 at 22 21 22@2x

@peppy thoughts on whether this should be addressed before lazer becomes "ranked"? since I believe by then many people would switch to lazer and would likely be confused when they can't search for their beatmaps due to being filtered out by the "Featured Artists" filter.

Tanza3D commented 12 months ago

Might be worth considering adding something underneath search results warning about it when none of the results match the query directly? Like so: image Would allow for there to be no warning when the user's searching for featured artist maps, and for it not to get too in the way when their search isn't successful. Would need some experimentation to figure out when best to display it though, I'd say when the song name, artist name, or mapper name don't match on any of the maps returned.

bdach commented 12 months ago

That looks potentially okay, but I'm not sure that particular design will work when there are zero results displayed. It'd probably have to replace the "... nope, nothing found" placeholder entirely. Or supplement it somehow.

Tanza3D commented 12 months ago

image Could possibly just append the message to the text like this? I personally feel like the no results found ui could do with a redesign in general, doesn't fit in too well with the UI in my opinion, but for now this would probably work.

edit: Putting it on another line could look a bit nicer possibly

peppy commented 12 months ago

While you're there maybe you could check out the song select placeholder we have (design done by me, nothing special) and update it to be in line with what we display here ;).

Tanza3D commented 12 months ago

Hmm which one, when there's no search results in song select? or something else?

peppy commented 12 months ago

Yep, it has a few different modes of display:

https://github.com/ppy/osu/assets/191335/5231ac76-cfde-4000-9a5f-4481dd7ccfe6

Tanza3D commented 12 months ago

Would it be viable to redesign the beatmap one completely to be reusable across multiple areas (including song select)? I feel that might be a good way forward. The image on the beatmap one doesn't fit too well in lazer's design language in my opinion, and especially would look out of place in song select.

Tanza3D commented 12 months ago

Something like this: image Unsure about the icon though

bdach commented 11 months ago

Looks somewhat okay to me, although some of the text alignment here looks off (I'd argue the bullet list needs to be indented more).

One other question I'd have is what to do when there's no actual results and no real good hint to give, I guess then you'd just keep the heading and skip the bullet list?

peppy commented 11 months ago

I'm not a huge fan on the proposed design. I'm hoping it can be something that feels nice, like the blank-expression-pippi, and meld a bit better than a mundane corner radius box.

Tanza3D commented 11 months ago

One other question I'd have is what to do when there's no actual results and no real good hint to give, I guess then you'd just keep the heading and skip the bullet list?

Yep, can just have the text

I'm not a huge fan on the proposed design. I'm hoping it can be something that feels nice, like the blank-expression-pippi, and meld a bit better than a mundane corner radius box.

I really feel the pippi is out of place and kind of jarring compared to the rest of the UI, though I'll try think up some other concepts. I think it'll be best to come up with something which can be used continually into the future in other UIs, including the multiplayer screen (which at the moment just shows a blank screen when there's no results)

Joehuu commented 6 months ago

Saw a reddit post about this again so trying to put this out of limbo.

Can we reuse the existing outdated country filter UI for this?

Screenshot 2024-03-22 at 11 42 28 PM

and show filtered by: ( Featured Artist X ) ( Ranked X ) ( ETC X )

This UI is similar to https://github.com/ppy/osu-web/issues/7372#issuecomment-1047485245 (just found this out while writing this).

Note that web uses a dropdown for the country now, so the above can be made abstract / repurposed for the beatmap listing as there are multiple filters.

Edit: And probably make pippi say "... nope, nothing found. maybe try removing the filter(s) above?" when there's no results. Otherwise the "filtered by" row should be obvious to the eye.

bdach commented 6 months ago

"Putting this out of limbo" is going to require someone to make a shotcall on the design part. I don't even know who at this point.

frenzibyte commented 6 months ago

@arflyte able to advise on design for https://github.com/ppy/osu/issues/22009#issuecomment-2016380074? we want to add a "filtered by" row in the beatmap listing page to make it clear to the user what filters they have active (see also https://github.com/ppy/osu-web/issues/7372#issuecomment-1047485245)

peppy commented 4 months ago

Saw a reddit post about this again so trying to put this out of limbo.

Can we reuse the existing outdated country filter UI for this?

Screenshot 2024-03-22 at 11 42 28 PM

and show filtered by: ( Featured Artist X ) ( Ranked X ) ( ETC X )

This UI is similar to ppy/osu-web#7372 (comment) (just found this out while writing this).

Note that web uses a dropdown for the country now, so the above can be made abstract / repurposed for the beatmap listing as there are multiple filters.

Edit: And probably make pippi say "... nope, nothing found. maybe try removing the filter(s) above?" when there's no results. Otherwise the "filtered by" row should be obvious to the eye.

both of these sound fine. we don't need a non-responsive designer to move forward with this IMO.

frenzibyte commented 3 months ago

Taking out of waiting-on-design label in compliance with the above (i.e. this is ready to be tackled).