search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.24k stars 2.27k forks source link

Implement osu!mania special styles #2203

Open smoogipoo opened 6 years ago

smoogipoo commented 6 years ago

osu!mania beatmaps have a SpecialStyle parameter that indicates whether they're 5K+1 or 7K+1 styled. This parameter should be used to determine whether the special column should be mirrored (see discussion in: https://github.com/ppy/osu/issues/2067).

The user is allowed the ability to customise where this location is (left/right of the stage), or whether it is displayed as a special column at all.

Most importantly, Beatmap should not house a SpecialStyle property. Perhaps the best way to do this is to store unhandled beatmap values inside a lookup table of sorts, and have the mania beatmap converter pull the property from that lookup table.

smoogipoo commented 11 months ago

I've stopped on this for the time being to take on more pressing tasks. In the path towards fixing this, I wanted to tackle the incorrect way in which "special style right" is implemented in osu-stable whereby it changes the display without moving around the columns.

WIP branch: https://github.com/smoogipoo/osu/tree/mania-scratch-style

It's mostly been abandoned because input needs consideration, and I've forgotten exactly how special styles are represented in replays.

peppy commented 10 months ago

Moving this out of the project for now, but keeping it highish priority.