ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.06k stars 2.23k forks source link

Unreasonable PP increase in overall ranking #22289

Open outfoxxed opened 1 year ago

outfoxxed commented 1 year ago

Type

Game behaviour

Bug description

Overall Ranking PP increase is completely wrong in most cases. I have noticed PP increasing in non-best plays (where a previous play with a higher score and PP is listed in the leaderboard), or PP just coming from nowhere (+52pp OVERALL on a 0pp play).

This is not just a clientside issue, as the increased overall PP shows up on https://lazer.ppy.sh.

Here's the osr for that (0pp) play (renamed to .txt so github will upload it) replay.osr.txt

Screenshots or videos

+52 overall PP from a 0pp play image image lazer.ppy.sh agrees that the play was 0pp, but also increased the overall PP image image

Version

2022.1228.0-lazer

Logs

database.log input.log network.log performance.log runtime.log

peppy commented 1 year ago

Overall PP also factors in play count I believe, which may be affecting your perception.

outfoxxed commented 1 year ago

Overall PP also factors in play count I believe, which may be affecting your perception.

Not sure what you mean by this. Previous plays could not have affected that score, as that was the first time I played that map.

I just had another play with a big difference (website shows 87pp, client shows 114pp - either one probably should've boosted my ranking, which didn't change at all (I also played another map after and it did not tack the increases from the previous play onto the results))

I'm assuming this discrepancy is just due to the web pp calculator updating on a schedule different from the client one, but I'm posting it here since it might be related.

image image

Replay file: replay.osr.txt (I have no idea if this is helpful)

peppy commented 1 year ago

What I was explaining is that each play gives bonus pp up to a certain target. It's not reliant on previous plays on the same beatmap. It only applies to first time playing.