ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.1k stars 2.24k forks source link

Small area between rankings and beatmap carousel that controls volume when scrollwheel is used #2238

Closed LittleEndu closed 1 year ago

LittleEndu commented 6 years ago

That small area doesn't exist in stable client and is really annoying. The entire area should scroll the carousel instead.

ticotaco72 commented 6 years ago

@LittleEndu but why not? thanks to that menu is very clear

LittleEndu commented 6 years ago

What menu? Also all that I am asking is for the area that scrolls the carousel to start at where the stats area ends

ticotaco72 commented 6 years ago

song select; sorry i thought that you thinked about graphical area not input area;

flashwave commented 6 years ago

i'd prefer the space for volume changing stays, changing the volume from song select is pretty bothersome otherwise

LittleEndu commented 6 years ago

forthepeople

In case you guys still want everything in beatmap selection screen to control volume...

flashwave commented 6 years ago

yeah that would make sense in my opinion, considering the details area has its own scrollable elements

radobot commented 4 years ago

Actually, depending on the resolution, the area between the two lists can be pretty big. (area sizes measured using Draw Visualiser)

scrolling areas

Coming from stable, I'm scrolling the song list pretty much exclusively using that green area (I guess it might be because I hate how it ticks when the mouse hovers over scrolling beatmaps. That and muscle memory probably too.). So for me not being able to scroll beatmaps without hovering over them is very frustrating. Since the action of selecting a beatmap is one of the most important and commonly performed actions, when it just feels wrong, it weights down heavily on the whole experience of using lazer.

My request would be to make the green area scroll the beatmap list. Exact shape is to be decided.

Also, it seems there's a PR that does this (https://github.com/ppy/osu/pull/8791), although it seems that there are some issues with it.

bdach commented 4 years ago

The linked PR did do this but personally I had an issue with how it worked with the design. I found the fact that the scroll wheel would work over the semi-transparent wedge problematic as I see it as the delimiter of the metadata/beatmap info section on the left from the actual carousel. I guess if the wedge was pushed further to the left (so that it ends somewhere inside the green area) I would have no issue with it myself.

radobot commented 4 years ago

Are you talking about the overlap in the top left corner of the green area? Couldn't that be solved by just changing the hierarchy/draw order (z-order)? If you're talking about the background separator on the right, that seems to me as a matter of just editing the sprites.

Personally I don't think it would matter much even if it was left unsolved.

bdach commented 4 years ago

No, I mean that I would like to see the design of song select adjusted to something like this on wider resolutions (rough proposal, don't take too seriously):

osu_2020-07-12_12-40-41

This way it would be clearer which part is the carousel and controls carousel scrolling and which is the metadata display, as least to me.

radobot commented 4 years ago

Ah, so that's what you meant. That would solve the issue you pointed out, but now the empty area between the background wedge and the beatmap list looks weird.

If the scrolling area was to be extended all the way to the left, then the edge of the details pane would essentially start doing the same work as the background wedge is doing. Then there would be two different edges for the same thing, which might become confusing. I wonder if the deeper problem might be that the wedge creates an edge between the carousel and empty space when what we want might be a lack of an edge.

In stable the beatmap list is just floating in space without any edges so there isn't any indication of where it ends. As a result the user doesn't have any expectations of where the control area of the beatmap list should end.

Personally I don't really care if the scrolling area extends all the way to the left or just half way into the green zone from my screenshot as long as I can hit that area with my mouse without any effort. Also, I don't really see what benefit that background wedge provides in the first place. But that might be just me who wants minimal UI (ex. I have gameplay UI turned off and use minimal possible UI scalling).

peppy commented 4 years ago

I honestly think we should move volume adjustment to the toolbar - have an icon you can hover and scroll to adjust it - or to the screen edge - move cursor to left edge of screen to reveal volume adjustment knobs.

radobot commented 4 years ago

move volume adjustment

I think that's a great idea mainly because: How often does one need to adjust volume? For me it's almost never, especially since lazer decreases volume when window loses focus. And now that I think about it, ever since volume adjustment has been added to the scroll wheel back in stable, vast majority of the time I used that feature was because I changed the volume by accident.

But that's just my experience. Is there any data about how people use the volume adjustment in general?

ziomek64 commented 2 years ago

Actually, depending on the resolution, the area between the two lists can be pretty big. (area sizes measured using Draw Visualiser)

scrolling areas

Coming from stable, I'm scrolling the song list pretty much exclusively using that green area (I guess it might be because I hate how it ticks when the mouse hovers over scrolling beatmaps. That and muscle memory probably too.). So for me not being able to scroll beatmaps without hovering over them is very frustrating. Since the action of selecting a beatmap is one of the most important and commonly performed actions, when it just feels wrong, it weights down heavily on the whole experience of using lazer.

My request would be to make the green area scroll the beatmap list. Exact shape is to be decided.

Also, it seems there's a PR that does this (#8791), although it seems that there are some issues with it.

+1 on that one. There should be more area on the green color where you could use absolute scrolling