ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.31k stars 2.28k forks source link

Error when exporting a skin with too long file name #22649

Closed monochrome22 closed 1 year ago

monochrome22 commented 1 year ago

Type

Game behaviour

Bug description

Because lazer uses the text from Author from skin.ini, the skin name can become very long, which will prevent exporting the skin due to file path being too long. Truncating the name to fit the file path limit should be fine.

My skin is a combination of many other skins, so in author I decided to write names of all the skins that I took elements from. This caused the full path to be too long.

This can be a serious issue, because if a player makes a custom skin with long text in author, then imports it into lazer, then deletes the original files, they won't be able to export it and they'll lose access to their files.

Screenshots or videos

exporterror

Version

2023.207.0

Logs

To reproduce the error I just made a random skin with long text in author. Relevant part:

2023-02-15 09:50:47 [error]: Could not export current skin: The filename, directory name, or volume label syntax is incorrect. : 'C:\Users\Admin\AppData\Roaming\osu\exports_Mint Mango [Mint_Mango] (AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123).osk_809b5bb3-06a2-4659-b0c1-0a46b7830632' 2023-02-15 09:50:47 [verbose]: ⚠️ Could not export current skin: The filename, directory name, or volume label syntax is incorrect. : 'C:\Users\Admin\AppData\Roaming\osu\exports_Mint Mango [Mint_Mango] (AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae123AxNae…

Cootz commented 1 year ago

Did game delete your skin in the process?

monochrome22 commented 1 year ago

No.

ppy-sentryintegration[bot] commented 1 year ago

Sentry issue: OSU-BW9