ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.33k stars 2.28k forks source link

decimal place bpms not being rounded when searching by bpm= #22772

Open ZythePDX opened 1 year ago

ZythePDX commented 1 year ago

Type

Game behaviour

Bug description

when some maps have bpms that that are in the decimal places and are rounded to the nearest bpm, and you try to search for the rounded bpm it does not show

ex: searching for a specific difficulty with bpm=180 does not work, but if you check the mapset on the website the bpm is 180.03 you have to search for that specific bpm for it to show https://osu.ppy.sh/beatmapsets/1036855#osu/2171716

looks like its shows in these beatmaps https://osu.ppy.sh/beatmapsets/1036855#osu/2171716 https://osu.ppy.sh/beatmapsets/859515#osu/2082009 https://osu.ppy.sh/beatmapsets/89799#osu/244487

note: sorry if my wording is bad

Screenshots or videos

https://user-images.githubusercontent.com/50603224/222639252-53b1e118-68b7-4450-aa4e-4435c3c5cb46.mp4

on stable

https://user-images.githubusercontent.com/50603224/222642489-efcb0a70-0c04-4e81-97e4-ec804a01e1cf.mp4

on lazer

https://user-images.githubusercontent.com/50603224/222642401-155c4904-4b26-4b51-828f-5f6eb6b9882f.mp4

Version

2023.301.0-lazer

Logs

network.log performance.log runtime.log updater.log database.log input.log

ZythePDX commented 1 year ago

sry I need to redo this, I figured out what was the problem

peppy commented 1 year ago

Is it fine to close the issue then?

ZythePDX commented 1 year ago

well I worded that badly, but what I meant so say is "I found out how the bug works I need to edit what I said". So I want to keep it open

bdach commented 1 year ago

The bpm filter was written this way with intention:

https://github.com/ppy/osu/blob/29be26b1504d7056b8182156f505a47519acf16e/osu.Game/Screens/Select/FilterQueryParser.cs#L58-L59 https://github.com/ppy/osu/blob/29be26b1504d7056b8182156f505a47519acf16e/osu.Game/Screens/Select/FilterQueryParser.cs#L195-L198

but I do agree it's not exactly user friendly. Maybe the tolerance there should be half-a-BPM rather than the current 0.005?