ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

Importing certain beatmaps doesn't import background image and/or video #23259

Closed Haspamelodica closed 1 year ago

Haspamelodica commented 1 year ago

Type

Game behaviour

Bug description

Importing certain beatmaps like https://osu.ppy.sh/beatmapsets/15639 doesn't import background images and videos. This is a regression from 2023.403.1.

Screenshots or videos

osu_2023-04-21_01-24-26

https://user-images.githubusercontent.com/46954095/233507359-a8a8ea6c-9aae-470d-a029-0928f10767a8.mp4

Version

2023.419.0

Logs

performance.log runtime.log updater.log database.log input.log

client.realm after import: client.realm.zip

Haspamelodica commented 1 year ago

This excerpt from runtime.log seems relevant:

2023-04-20 23:24:11 [verbose]: Texture could not be loaded via STB; falling back to ImageSharp: STBI could not load an image from the provided data: 浉条⁥潮⁴景愠祮欠潮湷琠灹ⱥ漠⁲潣牲灵t畏⁴景洠浥牯y
2023-04-20 23:24:11 [verbose]: 🌅 Background change queued
2023-04-20 23:24:11 [verbose]: Beatmap background failed to load (file Video.AVI not found on disk at expected location c\c0\c0281a94c9b982057e9211b9d3d4a816037b1d397b2d07b1d7c0c0d3f5879a13).
2023-04-20 23:24:11 [verbose]: Beatmap background failed to load (file Video.AVI not found on disk at expected location c\c0\c0281a94c9b982057e9211b9d3d4a816037b1d397b2d07b1d7c0c0d3f5879a13).
2023-04-20 23:24:11 [verbose]: Beatmap background failed to load (file Video.AVI not found on disk at expected location c\c0\c0281a94c9b982057e9211b9d3d4a816037b1d397b2d07b1d7c0c0d3f5879a13).
2023-04-20 23:24:14 [verbose]: Song select updating selection with beatmap:1ec8d164-0157-4b43-9d8e-9757d9fcff32 ruleset:osu
2023-04-20 23:24:14 [verbose]: Song select changing beatmap from "Nickelback - Savin' Me (YGOkid8) [Easy]" to "Nickelback - Savin' Me (YGOkid8) [Normal]"
2023-04-20 23:24:14 [verbose]: Game-wide working beatmap updated to Nickelback - Savin' Me (YGOkid8) [Normal]
2023-04-20 23:24:14 [verbose]: Song select working beatmap updated to Nickelback - Savin' Me (YGOkid8) [Normal]
2023-04-20 23:24:14 [verbose]: Beatmap background failed to load (file Video.AVI not found on disk at expected location c\c0\c0281a94c9b982057e9211b9d3d4a816037b1d397b2d07b1d7c0c0d3f5879a13).

However, the file c\c0\c0281a94c9b982057e9211b9d3d4a816037b1d397b2d07b1d7c0c0d3f5879a13 is definitely there, and VLC happily plays it.

Haspamelodica commented 1 year ago

A bisect seems to suggest da947d86613ffe99f19f4d49a6535810ba752c59 is the commit in which this was introduced.