ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

Hard linked beatmaps become empty if updated from osu!stable #23553

Closed Sinamer closed 1 year ago

Sinamer commented 1 year ago

Type

Game behaviour

Bug description

After hard linking beatmaps from osu!stable to lazer, launching stable and updating the beatmap, it will not properly show up in lazer anymore

Screenshots or videos

osu_2023-05-15_09-37-11

Version

2023.513.0

Logs

runtime.log

peppy commented 1 year ago

This sounds like a failure at a non-osu! level. Deleting a hard linked file elsewhere should not remove it from disk at all locations, which is what looks like has happened here.

Cannot repro.

Parallels Desktop 2023-05-16 at 04 27 41

https://github.com/ppy/osu/assets/191335/0134a7d0-96c1-455b-877c-0f8381286240

Sinamer commented 1 year ago

On a double check, following the process in OP indeed is not the cause as deleting or updating the map from stable works just fine. This is quite odd, a bunch of maps on lazer became empty, the only common denominator being that they were hard linked from stable, and all of those show either pending an update or got a "not submitted" status on stable: osu_2023-05-16_08-47-22 screenshot136 osu_2023-05-16_08-51-37 screenshot137 Closing as there are no details on how that happened. I have ran the import from stable process again which resolved those maps being empty, and will report back later if this shows up and I know what lead to it.

peppy commented 1 year ago

Did you happen to have a power / system failure at any point in the recent past? We've seen issues with zeroed files which can be attributed to such cases, and the use of unsafe file API. We've already fixed this in common save scenarios but there may be an edge case where it's not applied.

Sinamer commented 1 year ago

Yes, I have had to hard power off my laptop multiple times recently due to another game causing my system to freeze. I didn't have osu! open at those moments though, not sure if it would affect osu! folders