search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.39k stars 2.29k forks source link

Hit lighting fades out too fast while using classic mod fade setting with argon skin #23771

Open peppy opened 1 year ago

peppy commented 1 year ago

This is an implementation detail of the argon skin – hit lighting is actually inside the hit circle here while it isn't on the classic skins. Will need some consideration to make that work.

Discussed in https://github.com/ppy/osu/discussions/23442

Originally posted by **DarkbitNetwork** May 8, 2023 I have noticed that hit lighting fades out abnormally quick at the time when the option was available but I didn't bother asking until now. I know the hit circle is supposed to fade out earlier with the option enabled which obviously includes the hit lighting but I think this is way too fast. It's as if the hit lighting last only for 1 frame before instantly disappearing. **Is this intended to be the case?** ### Video: Recorded with OBS Studio 29.0.2 (64 bit) https://user-images.githubusercontent.com/43719333/236835591-8a8fefa7-e7d0-4c35-bf42-b029f6ac036d.mp4
frenzibyte commented 10 months ago

I've tried to look into this but it's too complicated with the fact that I literally cannot differentiate between hit lightning on/off on "argon" skin.