search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.3k stars 2.27k forks source link

Every tick of the metronome will cause the game to freeze briefly #24521

Closed Jan-Arbus closed 1 year ago

Jan-Arbus commented 1 year ago

Type

Performance

Bug description

It can be seen in the video that each tick of the metronome will cause the game to freeze briefly It seems that the longer the beatmap, the more serious the problem Beatmaps used in the video: https://osu.ppy.sh/beatmapsets/972#osu/9007 | https://osu.ppy.sh/beatmapsets/2459#osu/19753

Screenshots or videos

https://github.com/ppy/osu/assets/74862110/0c8f67e0-cacb-492a-a31c-4d081ffdd189

https://github.com/ppy/osu/assets/74862110/8e35e12e-8ed2-4909-a7b0-12473f427e39

Version

2023.812.0

Logs

database.log runtime.log performance.log network.log

longnguyen2004 commented 1 year ago

Taken to the extreme, Hello (BPM) 2022 is extremely laggy

image

bdach commented 1 year ago

20918

Jan-Arbus commented 1 year ago

20918

I don't think this problem is related to #20918, in the problem I reported, even only one time point will cause stuttering

bdach commented 1 year ago

@RBQcat then please attach a video of this showing with one time point rather than the tens or hundreds the maps in OP have. preferably also with frame graph enabled (ctrl-f11 twice).

Jan-Arbus commented 1 year ago

https://github.com/ppy/osu/assets/74862110/f2070cdf-7dea-4eea-a93c-d4d69abb2c73

In addition, I found that Caton appears after the waveform image is loaded

Lunarien commented 1 year ago

I am experiencing the same issue and found out that the main cause is the UI to the right of the metronome (metronome tick delay visualizer?). Whenever I hover over it and not move my cursor, it stops the updating and the lag is not caused anymore. I recorded a video of it, and I also show how I move my cursor over it like normal. That movement causes a giant lag. I am pretty sure it is the updating of this UI component that makes it all lag.

https://github.com/ppy/osu/assets/73956350/052abed0-42e7-4fe9-9bfa-a5702424e381

Lunarien commented 1 year ago

The metronome causes that UI component to update, which results in the metronome seemingly being the cause, but the cause is probably what the metronome affects.

Jan-Arbus commented 1 year ago

Fixed by https://github.com/ppy/osu-framework/pull/6009