ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.45k stars 2.3k forks source link

Skinned osu!mania notes may appear larger than expected (`WidthForNoteHeightScale` not implemented) #24664

Open RedAndBloo opened 1 year ago

RedAndBloo commented 1 year ago

Type

Cosmetic

Bug description

I recently converted to Laser. After doing so, the skin felt different. It added a glow when notes are hit. I fixed that, but it still felt off when playing. I discovered it's slightly bigger than in Osu and there's no way I could fix that. (On 21.5 inch, late 2012 mac.)

Minor issues I had when converting: I accidentally replaced Osu with Laser when moving it to desktop since both were named osu! When trying to remove the glow it added. I discovered no skin folder, so I couldn't change it in Laser. After unzipping a beatmap pack, they were in folders not .osk. There wasn't a songs folder, so I definitely had to redownload Osu.

Screenshots or videos

This is the skin https://drive.google.com/file/d/1E_mL48PtotGh2UYT0BBbm57AGlQQn57M/view. image Osu.

image Laser. I tweaked it a bit. In the original hitting notes has a glow.

Here's another similar skin https://www.mediafire.com/file/6233vhi1inmvs4x/sibal-.osk/file.

image Osu.

image Laser. It looks bigger in Laser. I'm not crazy, I swear.

Other keys look fine. It's just 4k four some reason.

Version

Osu: 20230814.2 Laser 2023.815.0

Logs

Osu runtime.log

Laser runtime 2.log performance.log

🤷

peppy commented 1 year ago

Please attach your full skin. It's going to be something in your config.

RedAndBloo commented 1 year ago

Here. Thanks!

Laser. keiibar [- Keii_s Mix (2)] (keiichi__).osk.zip Unmodified keiibar [- Keii_s Mix] (keiichi__).osk.zip

Osu keii_bar.osk.zip Unmodified keii_bar.osk 2.zip

peppy commented 1 year ago

The actual resources in your skin match what lazer is showing. Which makes me think that this line in your 4k config is actually what's giving you the shorter notes:

JetBrains Rider 2023-08-30 at 05 18 27

To confirm, could you check 7k on stable and see if it matches lazer? You only have this configuration set for 4k so checking any other key mode should be a good test.

RedAndBloo commented 1 year ago

Add WidthForNoteHeightScale to 7k? Alright. screenshot009

osu_2023-08-30_17-36-14

peppy commented 1 year ago

That's not what I meant. Just check 7k without changing anything. The sizes should match on lazer and stable if my theory is correct.

RedAndBloo commented 1 year ago

Yeah, they are. 👍 screenshot012

osu_2023-08-31_12-37-47

peppy commented 1 year ago

Thanks, that confirms what needs to be fixed to make this work for you.