4:3 background videos appear cropped on a 4:3 display

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.05k stars 2.22k forks source link

4:3 background videos appear cropped on a 4:3 display #24777

Open catsstuffs opened 1 year ago

catsstuffs commented 1 year ago

Type

Cosmetic

Bug description

despite the game matching the resolution of the source video, the video appears cropped, instead of fit to the screen. on this map, i have widescreen support off, so it would be expected for the video to appear with no cropping at all. this doesn't match the behavior on stable either

Screenshots or videos

Version

2023.908-2-lazer

Logs

updater.log input.log network.log runtime.log performance.log legacy-ipc.log database.log

peppy commented 1 year ago

This is a surprisingly deep issue.

The video scaling in stable always fills the full windows, and doesn't necessarily match storyboard. It's always scaled to take up the full window width regardless.
The background does too, but independently (so they might not ever match)

In lazer the video fills the storyboard region, which doesn't match the above. Making it match is non-trivial because of hierarchy.