ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

No hitsound when hit objects' volume is on 5% on lazer #25165

Closed SedjamTan closed 1 year ago

SedjamTan commented 1 year ago

Type

Game behaviour

Bug description

I noticed while playing this map that certain hit objects don't have a hitsound on lazer compared to stable. Upon checking the beatmap in the editor, those hitobjects have a volume of 5%.

Some of the hit objects with volume of 5%: 0:39:260 0:39:450 0:49:969 0:44:007 0:46:476

Screenshots or videos

Stable

https://github.com/ppy/osu/assets/62494738/de0c5a6d-f7cc-4c74-9785-de4abfbf3591

Lazer

https://github.com/ppy/osu/assets/62494738/bf5c5161-0b49-438b-a2a5-8218e2da6724

Version

2023.1008.1

Logs

performance.log runtime.log updater.log database.log network.log

peppy commented 1 year ago

Stable enforces a 5% minimum. It's probably not yet implemented.

bdach commented 1 year ago

Stable enforces a 5% minimum. It's probably not yet implemented.

Are you referring to this thing?

https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/Audio/AudioEngine.cs#L1070 https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/Audio/AudioEngine.cs#L1404-L1405

If yes, then that's 8%, but that still doesn't explain the massive volume difference. Whatever this thing is probably would though.

image

We already apply leniency here:

https://github.com/ppy/osu/blob/f36a671eb41dce6dd08169891e8992962930aa9f/osu.Game/Beatmaps/Formats/LegacyBeatmapDecoder.cs#L115

Not yet sure why it isn't enough in this case.