ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.42k stars 2.29k forks source link

Playlist items navigation functionality no longer works #25302

Open frenzibyte opened 1 year ago

frenzibyte commented 1 year ago

This has regressed with https://github.com/ppy/osu/commit/b9590320b750d64ed532ce0621f54019940c1f4c. Up and down arrow keys now go trough the textbox history instead of the playlist items, with no way to unfocus the text box.

Maybe this is fine as this is a niche use case and there's a workaround: bind Previous selection and Next selection to something other than (or the alphanumeric keys, as those are handled by the textbox when typing).

Originally posted by @Susko3 in https://github.com/ppy/osu/discussions/18061#discussioncomment-7414877

peppy commented 1 year ago

I think we can make the textbox unfocused by default, using tab to focus like in other places.

The-Grace-God commented 1 year ago

seeing how this works like alot of other things like terminals and just textboxes in general that most users are used to this behavior by default I'm not one of the devs but personally i don't see this as a big issue as you can just click out the box or press Enter when your don searching or if you accidentally press ↑ when searching its not that big of a deal as you already know what song or setting you were searching and saying how short both of those options are to type i don't see it being a big deal to just retype if you accidentally pressed ↑