search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

SkinEditor should not be able to switch music in Gameplay #25680

Closed Jan-Arbus closed 11 months ago

Jan-Arbus commented 11 months ago

Type

Game behaviour

Bug description

Use the edit button in the main menu to enter the skin editor Press Ctrl+T in the skin editor to bring up the Tool Bar Open the music overlay panel Click to switch music *Attempting to adjust the beatmaps progress at this time will cause the game to crash

Screenshots or videos

https://github.com/ppy/osu/assets/74862110/e9881f29-398e-489b-8827-3906eecab8e8

Version

2023.1130

Logs

runtime.log

Gabixel commented 11 months ago

I guess the ruleset selection should also be disabled. Fortunately, that one doesn't seem to cause any damage, but during gameplay even that is not selectable, for good measures.

(Actually, you could take advantage of that for the skin editor by adding the ability to change ruleset in this screen in real-time, or by restarting the autoplay.. which is probably an easier thing)

peppy commented 11 months ago

(Actually, you could take advantage of that for the skin editor by adding the ability to change ruleset in this screen in real-time, or by restarting the autoplay.. which is probably an easier thing)

Right now the toggle covers both beatmap and ruleset at the same time, so we can't really do this for now.