search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

Recent 20ms delay added to visual waveform cause some songs to render out of bound. #26202

Closed Trung0246 closed 10 months ago

Trung0246 commented 10 months ago

Type

Cosmetic

Bug description

I believe this is the root cause: https://github.com/ppy/osu/pull/26136

Is it possible to move the constant to a separate settings and set that value to 20 if we intend to keep that constant?

Affected songs: https://osu.ppy.sh/beatmapsets/2047843#osu/4275701 https://osu.ppy.sh/beatmapsets/1312305#osu/2719816 https://osu.ppy.sh/beatmapsets/1846720#osu/3793506 https://osu.ppy.sh/beatmapsets/1017505#osu/2129555

All of these songs have the characteristic of 0ms offset timing.

Screenshots or videos

Screenshot 2023-12-28 153937 Screenshot 2023-12-28 153843 Screenshot 2023-12-28 153621

Version

2023.1229.0-lazer

Logs

compressed-logs.zip

peppy commented 10 months ago

I believe you are misunderstanding. You NEED to time to the new offset as all players expect this timing.

You cannot use external waveforms to time. osu! beatmaps have an offset and with this change we calculated the offset to be applied to bring all waveforms in line.