argon and argon pro skin cause fps drop

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.2k stars 2.26k forks source link

argon and argon pro skin cause fps drop #26282

Open anispwyn opened 9 months ago

anispwyn commented 9 months ago

Type

Performance

Bug description

when using argon or argon pro (on both opengl and directx11) fps will suddently drop for some reason

i've tried on igpu (rx 680) and dgpu (using nvidia optimus)(RTX 3050ti mobile) gpu scheduling off and on make no different

my laptop specs: https://www.hp.com/th-en/shop/victus-by-hp-laptop-16-e1100ax-7a5z4pa.html (ram upgraded to 16gb)

Screenshots or videos

https://i.nuuls.com/ClaGc.mp4

when using argon:

when using legacy skin:

Version

2023.1229.1

Logs

compressed-logs.zip

anispwyn commented 9 months ago

Please use 2x/4x refresh rate rather than unlimited. Also, do not look too closely at the FPS counter, it's irrelevnat if you don't perceive any issue in performance (such as stuttering or constantly lagging), especially since it's already higher than 2x your monitor's refresh rate (assuming it's 144hz).

I understand what you trying to say

But the reason i'm opening this issue is because a specific skin cause fps drop which is very weird

anispwyn commented 9 months ago

But the reason i'm opening this issue is because a specific skin cause fps drop which is very weird

Its not like argon has any special element that legacy skin doesnt have (except instead of having 1 png cover all the screen, it just a bunch of elements)

peppy commented 9 months ago

Is probably glow shader related.

Feodor0090 commented 9 months ago

Similar issue here - this is what i see in latency sertifier: My gameplay usually can run at ~400-500 fps (if set to unlimited). UHD 630, latest Mesa, compositor disabled.

This "saw" on draw frame times is directly related to size of approach circle, which is drawn using border on a transparent box. Argon circles are drawn in a similar way.