Missing hitsounds in Editor in some 300BPM beatmaps

Yes, this is fixed by frame stability, but only because frame stability allows replay frames to exist in a non-linear time scale. As in there are frames in the past, and frame stability will rewind to handle them correctly.

The base issue is that hitobjects are closer than 50 ms in these beatmaps, but auto generator adds a 50 ms minimum window for key-down-to-key-up:

https://github.com/ppy/osu/blob/e182acf3e8c012fe36f8317d70ca7d6abe1803e9/osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs#L293

I'd argue that this should be solved by fixing the auto generator to infer the next object and not hold for as long, or just reducing the key down period altogether to a value which will not cause issues like this.

Side note that DelayedMovements in autogenerator is currently never used and a dead code path...

This is a duplicate of https://github.com/ppy/osu/issues/22353.

peppy commented 10 months ago

As this is a duplicate (and side effect of the larger issue), I'll close this in favour of #22353.

ppy / osu

Missing hitsounds in Editor in some 300BPM beatmaps #26366

Type

Bug description

Screenshots or videos

Version

Logs