search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.09k stars 2.24k forks source link

Skin names duplicates when importing them to lazer #26527

Open poketoine opened 8 months ago

poketoine commented 8 months ago

Type

Cosmetic

Bug description

When importing a skin to lazer multiple times, each time, it adds the name between brackets, thus making insanely long skin names. And I can't remove them. Wether it's by dragging it (the screenshot), or by importing it (the video)

Screenshots or videos

Capture d'écran 2024-01-14 130830

https://github.com/ppy/osu/assets/156585613/bafd68bf-29de-4f33-9592-4a6c3a485da7

Version

Lastest

Logs

compressed-logs.zip

bdach commented 8 months ago

Please attach the skin as zip.

poketoine commented 8 months ago

lazer_Draggondor.zip

@bdach Here you go

poketoine commented 7 months ago

Capture d'écran 2024-02-14 230937 Ok, I found out why the skin name duplicates itself, so I can close the issue. It can be nice that the game tells you when adding automatically the name to be sure that it doesn't reproduce

frenzibyte commented 7 months ago

That looks like lazer incorrectly appending the [General] section despite an existing one already being there. I'll keep this issue thread open to track that.

poketoine commented 7 months ago

ok, go on, thank you for caring about fixing the bug.

peppy commented 7 months ago

It looks like you're renaming the skin folder each time before re-importing to lazer. If this is the case, then it's intended to duplicate the skin because it's hard to tell whether you want to overwrite or import a new copy, so we prefer the one that doesn't lose data.