search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15k stars 2.21k forks source link

Argon skins ignore custom beatmap hitsounds on the osu!taiko ruleset #26774

Open NiceAesth opened 7 months ago

NiceAesth commented 7 months ago

Type

Game behaviour

Bug description

Currently, both the argon and argon pro skins ignore custom beatmap hitsounds in taiko. Tested on beatmap.zip

03:46:812 - hitsound expected to play, does not. Works on triangles and legacy skins.

Screenshots or videos

https://github.com/ppy/osu/assets/8437201/4c083997-793f-4837-ac98-4a5ba6349514

Version

master

Logs

1706528785.input.log 1706528785.network.log 1706528785.performance.log 1706528785.runtime.log 1706528785.database.log

frenzibyte commented 7 months ago

Argon skin has a completely separate way of playing samples, and it ignores whistle/finish ones: https://github.com/ppy/osu/blob/9bdc80a74934b781216ff924d5ccca79068e467e/osu.Game.Rulesets.Taiko/Skinning/Argon/ArgonDrumSampleTriggerSource.cs#L24-L44

Notice originalSample is the only thing played and it's either normal or clap.