submitted score randomly behaved incorrectly

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.46k stars 2.3k forks source link

submitted score randomly behaved incorrectly #27066

Open urayde opened 9 months ago

urayde commented 9 months ago

Type

Game behaviour

Bug description

this score was submitted and showing on the website with pp calculated (in recent plays, in pinned scores and map leaderboard), however it didn't appear on best performance scores either on lazer mode and standard, as well as it didn't award pp (even after submitting other scores).

Screenshots or videos

best performance in lazer mode

best performance in standard mode

map leaderboard

Version

2024.131.0-lazer

Logs

unfortunately game was closed before realizing and posting the issue

bdach commented 9 months ago

I'm pretty sure it's not in best because this score is set on the same map and has more pp.

It might have previously been the case that this would result in the pp value being shown as -, I believe on the reported score? So this'd be more of a display issue than anything.

urayde commented 9 months ago

I'm pretty sure it's not in best because this score is set on the same map and has more pp.

Not gonna lie I was dying from cringe to see this as we both (i reported this issue from my friend) didn't notice that map was fced before.

So this'd be more of a display issue than anything.

If I understood you correctly the issue is now about this score showing on map leaderboard instead of an fced one?

bdach commented 9 months ago

If I understood you correctly the issue is now about this score showing on map leaderboard instead of an fced one?

No I don't think that's right either.

Score leaderboards are ordered by score. Your friend's new score beat that old FC by like 9k score. So it showing there is correct.
It showing in recents is also correct because it is, well, recent.
It not showing in best performance is also correct because internally one score is stored per mod combination, and the best pp score is picked out of that for every beatmap. The classic score has more pp but less score.
What isn't correct is that I believe that before the pp launch if a score was in recents, but wasn't the best score pp-wise, it wouldn't show a pp value, but a - instead.

Does that sound vaguely correct?

urayde commented 9 months ago

Score leaderboards are ordered by score. Your friend's new score beat that old FC by like 9k score. So it showing there is correct.

Oh, yeah, I didn't notice I wasn't in lazer mode at the moment.

What isn't correct is that I believe that before the pp launch if a score was in recents, but wasn't the best score pp-wise, it wouldn't show a pp value, but a - instead.

I believe it was showing pp values if score was submitted with other mods and was best score pp-wise in exact mod combinations (in our situation classic and nomod), however if we take a look at other recent scores, the issue you mentioned seems real.

Also he submitted couple plays on stable (which are meant to be worse) and instead of - it shows that score is being calculated and marked for deletion, not sure if that's correct either.