search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.33k stars 2.28k forks source link

First notes/sliders stutter, but ui is not lagging #27071

Open InfernalRabbit opened 8 months ago

InfernalRabbit commented 8 months ago

Type

Performance

Bug description

When first note/slider near the map start it is always lagging and you can see it like a stutter

Screenshots or videos

https://github.com/ppy/osu/assets/3807400/94d11da8-b375-4ba1-9950-59dfd4ab8ed4

https://github.com/ppy/osu/assets/3807400/4caec450-ee52-4551-be5d-50855940b63e

Version

2024.131.0

Logs

compressed-logs.zip

EnergoStalin commented 8 months ago

Same thing mostly noticeable in slowmo 120fps capture

https://github.com/ppy/osu/assets/49844515/e1649f29-40ac-4064-b413-057ef348d626

Edit: map should be without skip at the start

peppy commented 8 months ago

Please confirm the issue is the same as https://github.com/ppy/osu/issues/22488. You can check this by confirming it only happens on certain beatmaps, where the first hitobject of the beatmap is close to 0 ms.

EVAST9919 commented 8 months ago

Also you can try removing pp counter from your skin.

It's allocating extensively during first few seconds after beatmap has been loaded which is causing multiple GC calls at the start of the map (duration differs form map to map) Снимок экрана 2024-02-11 212224 Снимок экрана 2024-02-11 213545 https://github.com/ppy/osu/pull/27114 will help with that a little (judgements will be omitted), but it wouldn't be enough. OsuStrainSkill is the main allocator and will need some thought.

But in theory this all should be happening during beatmap loading screen, and probably this call isn't blocking player from being loaded? I'm not sure with all that async flow. https://github.com/ppy/osu/blob/7bc571dd517bdcc5493eac8e28b2ea5309726591/osu.Game/Screens/Play/HUD/PerformancePointsCounter.cs#L83

InfernalRabbit commented 8 months ago

Please confirm the issue is the same as #22488. You can check this by confirming it only happens on certain beatmaps, where the first hitobject of the beatmap is close to 0 ms.

Seems like a part of it.I get this error from time to time. map desync with sound.

Also you can try removing pp counter from your skin.

Counter is not included in my setup, unfortunately when streaming on discord situation goes harder

This is new map with this error, if you play it with slowmo you can describe desync with sound and notes:

https://github.com/ppy/osu/assets/3807400/27eec385-d2da-4db0-95a2-b4844545e038 compressed-logs.zip