ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.46k stars 2.3k forks source link

replay bug and a little suggestion #27082

Open crystvl6mik opened 9 months ago

crystvl6mik commented 9 months ago

Type

Game behaviour

Bug description

when you start a replay that is not played to the end (that is, the person died in the middle of the map and he had a fail screen and saved the replay to F2) from the old osu to lazer, then after the player's death, the map continues to be played leaving the rest of the map in the misses. and I had to wait for the map to finish playing to see the results of the replay.

and another suggestion, when you restart the map, the BPM of the map was written, it can be useful when you start the map and forget what the BPM was

Screenshots or videos

No response

Version

lazer stable

Logs

-

bdach commented 9 months ago

when you start a replay that is not played to the end (that is, the person died in the middle of the map and he had a fail screen and saved the replay to F2) from the old osu to lazer, then after the player's death, the map continues to be played leaving the rest of the map in the misses. and I had to wait for the map to finish playing to see the results of the replay.

This doesn't sound right, replays are allowed to fail. Can you link the replay you're testing with? Is it a stable replay?

and another suggestion, when you restart the map, the BPM of the map was written, it can be useful when you start the map and forget what the BPM was

I'm not sure what this means?

cdwcgt commented 9 months ago

replays are allowed to fail, but the premise is that the rank is F if a failed replay export from stable, it's rank will not be F

https://github.com/ppy/osu/blob/7bc571dd517bdcc5493eac8e28b2ea5309726591/osu.Game/Screens/Play/ReplayPlayer.cs#L49

replay.zip

and another suggestion, when you restart the map, the BPM of the map was written, it can be useful when you start the map and forget what the BPM was

maybe mean write BPM in player loader? I'm not sure image

frenzibyte commented 9 months ago

Let's not combine two things in one issue thread please.