search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.29k stars 2.27k forks source link

Skin editor selection doesnt select components correctly #27464

Open u3o opened 7 months ago

u3o commented 7 months ago

Type

Other

Bug description

While selecting skin components using left click it doesnt select a component unless its 100% covered by the selection area (screenshot 1: you can see how i selected the whole screen and all of the components are inside the selection area but only the legacy length counter is selected)

And most of the time selecting the whole thing doesnt select the component, you have to select a way bigger area for selection to work. The combo counter is fully covered but still isnt selected (screenshot 2).

Expected behaviour: a component gets selected even when you select only a part of it.

Screenshots or videos

image

image

Version

2024.221.0-lazer

Logs

compressed-logs.zip

frenzibyte commented 7 months ago

Selection happens when the selection box meets the origin point of the object, I think we can improve that since we already have data about the bounds of the component.