osu!mania hold note tracking does not handle rewinding

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.15k stars 2.26k forks source link

osu!mania hold note tracking does not handle rewinding #27589

Open leKitsuna opened 6 months ago

leKitsuna commented 6 months ago

Type

Game behaviour

Bug description

When you watch autoplay, sometimes you can rewind the recording, which can cause the autoplay to miss.

Screenshots or videos

https://github.com/ppy/osu/assets/128412306/1b1571c5-0de7-4bce-a2ae-5b4b43556a8e

Version

2024.312.1-lazer

Logs

compressed-logs.zip

leKitsuna commented 6 months ago

And you can made autoplay lose with this bug. https://youtu.be/0FwZ916vzlc

frenzibyte commented 6 months ago

This is happening due to rewinding to a point at which a hold note was supposed to be in a held state. The hold note doesn't correctly track as being held.

From the video:

https://github.com/ppy/osu/assets/22781491/3ba97786-878f-4244-b24a-fe9e045153e1

Another example with argon skin for clarity:

https://github.com/ppy/osu/assets/22781491/fcdeea07-9cd6-4f91-af52-0e079ded7a3e