search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.09k stars 2.24k forks source link

audio or metronome goes off-sync when changing playback speed in editor #27727

Open c-sig opened 5 months ago

c-sig commented 5 months ago

Type

Game behaviour

Bug description

waveform should be consistently in sync with the sound heard regardless of playback speed

Screenshots or videos

https://github.com/ppy/osu/assets/61018516/519b92c4-afe3-4503-ba12-f17e637dd4b2

Version

2024.312.1-lazer

Logs

compressed-logs.zip

longnguyen2004 commented 5 months ago

This delay only happens when playback is started right at a metronome tick, it doesn't happen during normal playback.

tybug commented 5 months ago

Can you provide some timestamps or exact descriptions of what you expect to happen? Are you just pointing out that when changing playback speed (e.g. at 0:52), the current position in the timeline jumps, when you expect it to remain stationary?

Gabixel commented 5 months ago

I don't want to be wrong (since it took me a while to understand too) @tybug, but I think he's referring to the fact that the editor "tick" sound is not synced (to the "tick" sound in his audio track) if the playback speed changes / is low (or vice-versa: the track is off-sync when it's slowed down?). I think I can hear the different distance between the two "tick"s when the track speed changes, but it's very subtle.

bdach commented 5 months ago

https://github.com/ppy/osu/pull/26707 probably fixes this but has unresolved reviews.

c-sig commented 5 months ago

I think I can hear the different distance between the two "tick"s when the track speed changes, but it's very subtle.

specifically talking about this

though

current position in the timeline jumps, when you expect it to remain stationary?

might be related but not really my main concern

bdach commented 5 months ago

I'm gonna tentatively close this with the hopes that https://github.com/ppy/osu/pull/26707 is indeed the fix here. If that turns out to be wrong please report back after next release and we'll reopen.

c-sig commented 5 months ago

https://github.com/ppy/osu/assets/61018516/a32ee23e-db9d-4077-b79d-6040fe031c49

still the case in 2024.412.1-lazer

peppy commented 5 months ago

This is likely going to be caused by what is explained in https://github.com/ppy/osu/discussions/27826.

Basically the point of reference for adjusting offsets when rate adjusts are involved is currently incorrect (the "visual" waveform offset is not baked in to the base timing values).

Walavouchey commented 5 months ago

@ppy/team-client since this was reopened

peppy commented 5 months ago

a bit late