Spinner "MAX" on custom skins is confusing.

aL1NaZ4R commented 4 months ago

Type

Game behaviour

Bug description

Hi. osu!lazer has a lot of differences in gameplay compared to Stable, like Spinner Bonus limitation. And it's intended to display a MAX Text, but only for Argon skin. This is what happens if you reach the Spinner Bonus limit, while using a Custom Skin:

https://github.com/ppy/osu/assets/89677246/0500c7fd-2811-44a6-9c3d-3d014b5547ea

... and it's a little confusing.

We can have a spinner-max.png asset in skin files. If the Skin doesn't have this resource included, then display Torus "MAX" text instead. (I decided to do this myself and do a PR but I don't have any noticable coding knowledge)

Screenshots or videos

No response

Version

2024.412.1

Logs

compressed-logs.zip

nagi-desuuu commented 4 months ago

Just want to put it out that my skin has spinnerbonus-max.wav and it works.

https://github.com/ppy/osu/assets/75596775/dcf646f8-414d-4549-8937-bd48a3fe960b

aL1NaZ4R commented 4 months ago

Just want to put it out that my skin has spinnerbonus-max.wav and it works.

Aoh, didn't know. Thanks for mentioning this❤🙏

Electfried commented 3 months ago

I wonder if it would be possible to allow for the RPM stuff on spinners to be adjusted in the skin layout editor to prevent it overlapping with the hit error meter if you're like me and play with it at the bottom of your screen.

aL1NaZ4R commented 3 months ago

Edit: made it more understandable + corrected by facts that others added

ppy / osu