ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.72k stars 2.18k forks source link

Applause music doesn't stop playing randomly after closing result screen #27917

Open aL1NaZ4R opened 3 months ago

aL1NaZ4R commented 3 months ago

Type

Crash to desktop

Bug description

Hi. I'm using a custom skin and it has it's own Applause music. sometimes, this music doesn't stop playing, even after closing the result screen, and even after starting to play another beatmap, and only way is to wait until it ends. And this happens completely random, so I can't predict it to record a video, but I attached the logs, and I did export it right after this happened.

Screenshots or videos

No response

Version

2024.412.1

Logs

compressed-logs.zip

peppy commented 1 month ago

This is another case of sample playback relying on disposal to cease. I know we've had to fix this in other locations. I can't immediately see why this would happen (the playback starts in a Schedule call so the drawable should be in a completely loaded state and therefore be destroyed along with the results screen).