ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.67k stars 2.17k forks source link

Fix main menu button backgrounds not covering their entire width sometimes #28358

Closed bdach closed 1 month ago

bdach commented 1 month ago

Regressed in https://github.com/ppy/osu/pull/28195

I thought I had fixed this already once but it still looks broken. Basically when hovering over main menu buttons every now and then it will look like their backgrounds are not covering their entire width when they expand.

See video below for what I'm seeing. This isn't visible when using the test browser's rate feature, I basically had to record this in realtime and then re-record VLC slowly playing that recording back to illustrate this clearly.

https://github.com/ppy/osu/assets/20418176/45226058-550b-48b8-9f07-d28841f71585

The removed X position set looks wrong to me when inspecting the draw visualiser with the element because the element looks to be off centre horizontally, and removing it fixes that.

master this PR
1717058510 1717058043