ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.37k stars 2.28k forks source link

Can RulesetContainer<TObject> be derived? #2837

Closed tom-arrow closed 6 years ago

tom-arrow commented 6 years ago

2 options:

1. RulesetContainer<TPlayfield, TObject> should be derived instead of RulesetContainer<TObject> That would mean there's a typo here: https://github.com/ppy/osu/blob/b9d63ee7b1e6cb27d1c516c6bb7a87e456353cb1/osu.Game/Rulesets/UI/RulesetContainer.cs#L158-L162 And OsuRulesetContainer should extend RulesetContainer<OsuPlayfield, OsuHitObject> https://github.com/ppy/osu/blob/58b551b98ee9d2d9017df8bb2f9aadc7af9eebf7/osu.Game.Rulesets.Osu/UI/OsuRulesetContainer.cs#L21

2. RulesetContainer<TObject> can be derived. These lines should be removed: https://github.com/ppy/osu/blob/b9d63ee7b1e6cb27d1c516c6bb7a87e456353cb1/osu.Game/Rulesets/UI/RulesetContainer.cs#L157-L159

smoogipoo commented 6 years ago

1 is the way to go.