search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.67k stars 2.17k forks source link

Add support for combo counter from legacy mania skins #28391

Closed TheEZIC closed 1 month ago

TheEZIC commented 1 month ago

Move all code from LegacyComboCounter to LegacyBaseComboCounter. We don't need ISerialisableDrawable implementation for LegacyManiaComboCounter. I made it like this because we can't move mania ComboCounter without configuration changes.

Made LegacyManiaComboCounter from LegacyBaseComboCounter.

Move logic of hiding default combo counter element from CatchLegacySkinTransformer to LegacySkinTransformer because we need to hide default combo counter in mania as well.

Add ShouldRoll property to BaseComboCounter. That property toggles rolling of combo counter and removes 'x' symbol at the end of it.

longnguyen2004 commented 1 month ago

Is this related to #26254?

bdach commented 1 month ago

Is this related to #26254?

It sure looks like this to me, and some of the changes made in this pull on a 5-second skim make it dead-on-arrival as far as I'm concerned.

The other series has the right idea on how to execute this. This PR does not.