ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.15k stars 2.25k forks source link

General Touchscreen Rebalance #28396

Open BenZeng04 opened 4 months ago

BenZeng04 commented 4 months ago

This is a refactored version of https://github.com/TDRework/osu/tree/touchscreen-rebalance with significantly reduced runtime.

The proposal overhauls the touchscreen star-rating system, replacing the existing flat exponential to aim star rating with a probabilistic estimation of which hand is used to hit each individual object, maintaining a list of the most likely sequences while calculating difficulty.

All the changes in this PR (and in the previous version) are outlined in https://docs.google.com/document/d/1LWP7W5A5pghMpfXY0cj1v-ODjZsApe-MP2n7PvPOjYs/edit#heading=h.2910458agvn1.

Givikap120 commented 4 months ago

I feel like this PR heavily needs general pp refactoring first Removing independent skills system and implementing single Skills class where one skill can depend on another Cuz without this the PR looks very messy, with all those copies