search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.65k stars 2.17k forks source link

Slider head circle textures are size constrained and may not render completely #28422

Closed vicky5124 closed 4 weeks ago

vicky5124 commented 4 weeks ago

Type

Cosmetic

Bug description

When a sliderstartcircle skin element is (approximately) over twice as big as the circle size, the texture gets cut out in a square pattern, which is not only ugly and distracting, but it's also a miss-match between the behaviour in stable.

The map used in the screenshots is Tenacious D - BEELZEBOSS (THE FINAL SHOWDOWN), but the bug is reproducible in any map, with any CS (from 0 to 11), in gameplay, the map editor, and the skin editor.

Note that this issue may exist in other skin elements such as hitcircle, but I did not test for this because modifying skin elements in lazer is annoying, unergonomic, and there's no way to identify different versions of the skin in the list without changing the skin name in the skin.ini file on every modification.

Screenshots or videos

osu!lazer sceenshots showing the bug in gameplay and the editor: osu_2024-06-07_11-25-20 osu_2024-06-07_11-25-23 osu_2024-06-07_12-48-34

osu!stable showing the intended look. screenshot002 screenshot004

The skin elements used. Taken from boom 0524 edit (spro_-GN).osk sliderstartcircle@2x sliderstartcircleoverlay@2x

Version

2024.521.2

Logs

compressed-logs.zip

bdach commented 4 weeks ago

This is an intentional departure from stable. Please read https://github.com/ppy/osu/pull/25023 for context.