Restart on fail triggered in incorrect mod

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

14.65k stars 2.17k forks source link

Restart on fail triggered in incorrect mod #28434

Open MingxuanGame opened 3 weeks ago

MingxuanGame commented 3 weeks ago

Type

Game behaviour

Bug description

I used Sudden Death (Restart on fail: off) and Accuracy Challenge (Restart on fail: on). When SD triggered fail, game restarted.

Reason: https://github.com/ppy/osu/blob/be48377c4c2ab1155f501887021233ce83222d73/osu.Game/Screens/Play/Player.cs#L958-L959

It used AC's setting.

Screenshots or videos

https://github.com/ppy/osu/assets/68982190/a181e71a-1ac7-467c-9722-52e6efb54d79

Version

2024.521.2

Logs

BlockHead007 commented 3 weeks ago

Don't think if this is an issue as it is intentional

bdach commented 3 weeks ago

I wouldn't say it's intentional. Seems like an oversight to me, but a bit of an annoying one to address (will need to ferry across information which mod specifically triggered the failure).